Skip to content

Conversation

martakam
Copy link
Member

@martakam martakam commented Nov 7, 2026 •

This PR sets up Playwright for end to end testing of our app.

Many of the accessibility tests fail. These will be fixed in this PR: #107, which is a continuation of this one.

Closes #101

@martakam martakam self-assigned this Nov 7, 2026
@martakam martakam added the test Writing/editing tests label Nov 7, 2026
@martakam martakam added this to the Deliverable 4 milestone Nov 7, 2026
@martakam martakam linked an issue Nov 7, 2026 that may be closed by this pull request
@martakam martakam changed the title Test/e2e test: add E2E tests using Playwright Nov 7, 2026
@martakam martakam marked this pull request as ready for review November 7, 2026 23:55
@martakam martakam requested a review from a team as a code owner November 7, 2026 23:55
@martakam
Copy link
Member Author

martakam commented Nov 8, 2026

We want these E2E tests in CI as well. We have gotten access to add self-hosted runners now, so fd23410 is now outdated.

Converting this back into a draft until CI has been set up.

@martakam martakam marked this pull request as draft November 8, 2026 15:25
Explanation for this change is included in
the project choices and reasoning
The VM is too weak. Let's use CI for linting and formatting instead,
which still adds value, while not being so compute-heavy
@martakam
Copy link
Member Author

martakam commented Nov 8, 2026

Unfortunately, the VM is too slow to realistically run all of our E2E tests without waiting multiple minutes.
This also slows down our VM and could interfere with our app that we're hosting.

I suggest we use CI for linting and formatting, and I've set up an own issue for this: #110

This PR is now fully ready for review.

@martakam martakam marked this pull request as ready for review November 8, 2026 16:56
Playwright no longer runs in CI, so
remove all config that was related to that
@johahor
Copy link
Member

johahor commented Nov 10, 2026

Looks good. Only thing I'm wondering about is if we should delete the test users after the tests have run to avoid piling up test users. I'm approving, and we can decide on this, and make a new issue for it if we want.

@johahor johahor merged commit 4de9a03 into main Nov 10, 2026
@martakam martakam deleted the test/e2e branch November 11, 2026 21:59
Sign in to join this conversation on GitHub.
Labels
test Writing/editing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: add E2E tests
2 participants