-
Notifications
You must be signed in to change notification settings - Fork 0
test: add E2E tests using Playwright #106
Merged
+686
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
We need to request to get a GitHub runner added first
|
We want these E2E tests in CI as well. We have gotten access to add self-hosted runners now, so fd23410 is now outdated. Converting this back into a draft until CI has been set up. |
We have now gotten access to add a self-hosted GitHub runner
Explanation for this change is included in the project choices and reasoning
The VM is too weak. Let's use CI for linting and formatting instead, which still adds value, while not being so compute-heavy
|
Unfortunately, the VM is too slow to realistically run all of our E2E tests without waiting multiple minutes. I suggest we use CI for linting and formatting, and I've set up an own issue for this: #110 This PR is now fully ready for review. |
Playwright no longer runs in CI, so remove all config that was related to that
|
Looks good. Only thing I'm wondering about is if we should delete the test users after the tests have run to avoid piling up test users. I'm approving, and we can decide on this, and make a new issue for it if we want. |
johahor
approved these changes
Nov 10, 2026
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up Playwright for end to end testing of our app.
Many of the accessibility tests fail. These will be fixed in this PR: #107, which is a continuation of this one.
Closes #101